Skip to content

Update SecurityTransparentAttribute.xml #3312

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Oct 10, 2019
Merged

Update SecurityTransparentAttribute.xml #3312

merged 4 commits into from
Oct 10, 2019

Conversation

jkotas
Copy link
Member

@jkotas jkotas commented Oct 8, 2019

Summary

Add note that partial trust code is no longer supported.

@jkotas
Update SecurityTransparentAttribute.xml
fafac03 
Add note that partial trust code is no longer supported.
jkotas
jkotas commented Oct 8, 2019
View reviewed changes
xml/System.Security/SecurityTransparentAttribute.xml Outdated
@@ -40,6 +40,8 @@
<format type="text/markdown"><![CDATA[

## Remarks
Partially trusted code is not longer supported. This attribute has no effect in .NET Core.
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rpetrusha I would like to add this note to all attributes related to partially trusted code and code access security. Could you please take a look whether what I got is appropriate? Once we agree on the note text, I am going to copy&paste it into all affected attributes.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit, not->no

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Text looks good to me now with the fix.

@jkotas
Copy link
Member Author

jkotas commented Oct 8, 2019

cc @jaredpar

jkotas
jkotas commented Oct 9, 2019
View reviewed changes
@mairaw mairaw added this to the October 2019 milestone Oct 9, 2019
@mairaw mairaw added the doc-enhancement Improve the current content label Oct 9, 2019
rpetrusha
rpetrusha approved these changes Oct 9, 2019
View reviewed changes
Copy link

@rpetrusha rpetrusha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've corrected the typo and suggested an additional change, @jkotas. You can decide whether you'd like a note/important box or not and merge when you're ready.

@rpetrusha
Copy link

Is this ready to merge, @jkotas? Have you added the note to all the attributes that require them?

@jkotas
Copy link
Member Author

jkotas commented Oct 10, 2019

Yes, this is ready to merge

@jkotas
Copy link
Member Author

jkotas commented Oct 10, 2019

Yes, the note should be on all attributes.

@rpetrusha
Copy link

Thanks, @jkotas. I'll merge now.

@rpetrusha rpetrusha merged commit c455b85 into master Oct 10, 2019
@rpetrusha rpetrusha deleted the jkotas-patch-1 branch October 10, 2019 17:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danmoseley danmoseley danmoseley left review comments

@mairaw mairaw mairaw left review comments

@jaredpar jaredpar jaredpar approved these changes

+1 more reviewer

@rpetrusha rpetrusha rpetrusha approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees

@jkotas jkotas

Labels
doc-enhancement Improve the current content
Projects
None yet
Milestone
October 2019
Development

Successfully merging this pull request may close these issues.
5 participants
@jkotas @rpetrusha @jaredpar @danmoseley @mairaw